Formatting of generators changed without sufficient consensus
Problem
I noted in #3903 that the formatting of generators was recently changed based on an issue (#7028) that had a total of just 2 up-votes (excluding the OP's). I was under the impression that such changes would require far more consensus and motivation. There are issues with many more votes that have not yet even been considered. I'm opening this issue to suggest that the relevant changes be reverted until a proper process has been followed. FWIW, the original arguments didn't seem that compelling to me, but ultimately this is a very subjective matter and there isn't really a right or wrong answer. However, the change should only be made if there are either objective reasons to do so, or a really high percentage of votes in favour of the change. I'd like to avoid discussing the pros and cons in this issue, as that can be done elsewhere.
Unverified for your environment
Select your OS to check compatibility.
1 Fix
Revert Recent Generator Formatting Changes
The recent changes to the formatting of generators were made based on a discussion that lacked sufficient consensus, as evidenced by the low number of up-votes (only 2) on the related issue. This indicates that the community did not have a strong agreement on the need for such changes, leading to potential dissatisfaction among users who preferred the previous formatting style.
Awaiting Verification
Be the first to verify this fix
- 1
Identify the Commit to Revert
Locate the commit hash that introduced the changes to the generator formatting. This can typically be found in the version control history of the repository.
bashgit log --grep='generator formatting' - 2
Revert the Commit
Use the identified commit hash to revert the changes made to the generator formatting. This will restore the previous formatting style.
bashgit revert <commit-hash> - 3
Run Tests to Ensure Functionality
After reverting the commit, run the existing test suite to ensure that the functionality remains intact and that no new issues have been introduced.
bashnpm test - 4
Open a New Discussion for Community Feedback
Create a new issue or discussion thread to gather community feedback on the generator formatting. This should include a proposal for a more structured voting process for future changes.
Validation
Confirm that the generator formatting has been reverted by reviewing the codebase and ensuring that the previous formatting style is restored. Additionally, verify that all tests pass without any errors.
Sign in to verify this fix
Environment
Submitted by
Alex Chen
2450 rep