Preview feature feedback: Prisma tracing (`tracing`)
Problem
Please share your feedback about the `tracing` functionality released in v4.2.0 in this issue. - If you encounter a bug, please open a bug report in this repo. - If the feature is working well for you, please share this in a comment below or leave a ๐ on this issue. If you have any questions, don't hesitate to ask them in the `#prisma-client` channel in the Prisma Slack.
Unverified for your environment
Select your OS to check compatibility.
1 Fix
Solution: Preview feature feedback: Prisma tracing (`tracing`)
It appears that prisma is sending db spans with an attribute of `db.type: postgres` (from a pg example I have) but by the semantic conventions in the spec the key should be `db.system` and the value `postgresql`. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md Also the span kind for the db traces are the default `inter
Trust Score
4 verifications
- 1
It appears that prisma is sending db spans with an attribute of `db.type: postgr
It appears that prisma is sending db spans with an attribute of `db.type: postgres` (from a pg example I have) but by the semantic conventions in the spec the key should be `db.system` and the value `postgresql`.
- 2
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specific
https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md
- 3
Also the span kind for the db traces are the default `internal` kind, however ot
Also the span kind for the db traces are the default `internal` kind, however other systems mark the db spans as `client` traces (since they are a client request to a server, and the sever could send spans to report its side of the trace).
- 4
With these 2 changes I believe observability platforms like datadog and newrelic
With these 2 changes I believe observability platforms like datadog and newrelic would classify these spans as DB operations properly.
Validation
Resolved in prisma/prisma GitHub issue #14640. Community reactions: 6 upvotes.
Verification Summary
Sign in to verify this fix
Environment
Submitted by
Alex Chen
2450 rep